Subject: Re: [PATCH] powerpc: Add xmon function to dump 44x TLB

From: Benjamin Herrenschmidt <[email-masked]>
Date: Sat, 17 Nov 2007 08:04:27 +1100

On Fri, 2007-11-16 at 17:09 +0100, Segher Boessenkool wrote:
> >> +#ifdef CONFIG_44x
> >> +static void dump_tlb_44x(void);
> >> +#endif
> >
> > No need to #ifdef this...
> >
> >> +#ifdef CONFIG_44x
> >> +static void dump_tlb_44x(void)
> >> +{
> >
> > ...or this.
> 
> Erm actually, that last one would give you a compiler warning ("function
> defined but not used"), unless you convert the point where it is used to
> a plain "if" too -- probably not worth it until we have 32-bit 
> multiplatform
> support :-)

We do have multiplatform support but not accross CPU families :-)

Ben.