From: Li Li <r64360@freescale•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>,
Gala Kumar <kumar.gala@freescale•com>,
Li Tony <Tony.Li@freescale•com>
Subject: Re: [PATCH] Add IPIC MSI interrupt support
Date: Mon, 03 Dec 2007 12:59:33 +0800 [thread overview]
Message-ID: <1196657973.9642.28.camel@Guyver> (raw)
In-Reply-To: <20071203015209.GD26919@localhost.localdomain>
On Mon, 2007-12-03 at 09:52 +0800, David Gibson wrote:
> On Fri, Nov 30, 2007 at 11:48:39AM +0800, Li Li wrote:
> > The IPIC MSI is introduced on MPC837x chip.
> > Implements the IPIC MSI as two level interrupt controller.
> >
> > Signed-off-by: Tony Li <tony.li@freescale•com>
> > ---
> > arch/powerpc/boot/dts/mpc8377_mds.dts | 14 ++
> > arch/powerpc/boot/dts/mpc8378_mds.dts | 14 ++
> > arch/powerpc/boot/dts/mpc8379_mds.dts | 14 ++
> > arch/powerpc/platforms/83xx/Kconfig | 6 +
> > arch/powerpc/platforms/83xx/mpc837x_mds.c | 11 +
> > arch/powerpc/sysdev/Makefile | 1 +
> > arch/powerpc/sysdev/ipic_msi.c | 359
> +++++++++++++++++++++++++++++
> > include/asm-powerpc/ipic_msi.h | 54 +++++
> > 8 files changed, 473 insertions(+), 0 deletions(-)
> > create mode 100644 arch/powerpc/sysdev/ipic_msi.c
> > create mode 100644 include/asm-powerpc/ipic_msi.h
> >
> > diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
> b/arch/powerpc/boot/dts/mpc8377_mds.dts
> > index 1f7819e..1068fe2 100644
> > --- a/arch/powerpc/boot/dts/mpc8377_mds.dts
> > +++ b/arch/powerpc/boot/dts/mpc8377_mds.dts
> > @@ -210,6 +210,20 @@
> > #interrupt-cells = <2>;
> > reg = <700 100>;
> > };
> > +
> > + ipic-msi@7c0 {
> > + compatible = "fsl,ipic-msi";
> > + reg = <7c0 40>;
> > + interrupts = < 43 8
> > + 4 8
> > + 51 8
> > + 52 8
> > + 56 8
> > + 57 8
> > + 58 8
> > + 59 8 >;
> > + interrupt-parent = < &ipic >;
> > + };
>
> I'm not sure why the MSI needs a device node of its own. What actual
> piece of hardware is this representing?
>
The IPIC MSI has its own registers which control the mask and ack of MSI
interrupt. Furthermore, IPIC MSI is the second level interrupt
coontorller which connected to IPIC, to compatible with IPIC OF routine
interface, we need a device node.
> --
> David Gibson | I'll have my music baroque, and my
> code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
>
- Tony
next prev parent reply other threads:[~2007-12-03 5:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 3:48 [PATCH] Add IPIC MSI interrupt support Li Li
2007-12-03 1:52 ` David Gibson
2007-12-03 4:59 ` Li Li [this message]
2007-12-03 4:02 ` Michael Ellerman
2007-12-03 9:07 ` Li Li
2007-12-03 21:03 ` Benjamin Herrenschmidt
2007-12-04 1:41 ` Li Li
2007-12-04 5:38 ` Michael Ellerman
2007-12-04 7:51 ` Benjamin Herrenschmidt
2007-12-04 9:10 ` Li Li
2007-12-04 10:34 ` Li Tony
2007-12-04 12:04 ` Michael Ellerman
2007-12-04 13:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196657973.9642.28.camel@Guyver \
--to=r64360@freescale$(echo .)com \
--cc=Tony.Li@freescale$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox