Subject: Re: [PATCH 19/25] powerpc: Wire up PCI on Bamboo board

From: Benjamin Herrenschmidt <[email-masked]>
Date: Sun, 09 Dec 2007 18:03:25 +1100

> > +			/* Walnut has all 4 IRQ pins tied together per slot */
> 
> Not a Walnut board.

Right, though the IRQ routing is similar (the comment is correct)

> > +			interrupt-map-mask = <f800 0 0 0>;
> > +			interrupt-map = <
> > +				/* IDSEL 1 */
> > +				0800 0 0 0 &UIC0 1c 8
> > +
> > +				/* IDSEL 2 */
> > +				1000 0 0 0 &UIC0 1b 8
> > +
> > +				/* IDSEL 3 */
> > +				1800 0 0 0 &UIC0 1a 8
> > +
> > +				/* IDSEL 4 */
> > +				2000 0 0 0 &UIC0 19 8
> > +			>;
> > +		};
> >  	};
> > 
> >  	chosen {
> >  		linux,stdout-path = "/plb/opb/serial@ef600300";
> > -		bootargs = "console=ttyS0,115200";
> 
> Did you remove that for a reason?

Yes, and I want to do a pass removing all the occurences of bootargs in
the .dts file, it has absolutely nothing to do there (in theory nothing
in /chosen though linux,stdout-path can probably be argued and happens
to be handy but not bootargs).

Ben.