Subject: Re: [PATCH 19/20] [POWERPC] pci32: 4xx embedded platforms want to reassign all PCI resources

From: Benjamin Herrenschmidt <[email-masked]>
Date: Fri, 14 Dec 2007 07:37:23 +1100

> This one is slightly broken in my opinion.  You've added
> the ppc_pci_flags to all of these platforms, which is fine for your
> intended goal.  But now all of these platforms _have_ to compile with
> PCI enabled or they'll break with:
> 
> arch/powerpc/platforms/built-in.o: In function `walnut_probe':
> walnut.c:(.init.text+0x9a): undefined reference to `ppc_pci_flags'
> walnut.c:(.init.text+0xa6): undefined reference to `ppc_pci_flags'
> make[1]: *** [.tmp_vmlinux1] Error 1
> 
> So to do it correctly we need to either select CONFIG_PCI for all of
> them, wrap the ppc_pci_flags assignment in #ifdef CONFIG_PCI, or move
> the ppc_pci_flags variable declaration into something that always gets
> compiled.

Hrm... PCI is user selectable ? Forgot about that ...

All those platforms have PCI slots, so we may as well select it in
Kconfig... I'd rather avoid #ifdef's

Ben.