From: Kay Sievers <kay.sievers@vrfy•org>
To: Greg KH <gregkh@suse•de>
Cc: Markus Rechberger <markus.rechberger@amd•com>,
Timur Tabi <timur@freescale•com>,
PowerPC dev list <Linuxppc-dev@ozlabs•org>
Subject: Re: Fix Firmware class name collision
Date: Sat, 15 Dec 2007 16:46:55 +0100 [thread overview]
Message-ID: <1197733615.19869.30.camel@lov.site> (raw)
In-Reply-To: <20071215063917.GA14942@suse.de>
On Fri, 2007-12-14 at 22:39 -0800, Greg KH wrote:
> On Sat, Dec 15, 2007 at 05:14:29PM +1100, Benjamin Herrenschmidt wrote:
> >
> > On Fri, 2007-12-14 at 14:40 -0800, Greg KH wrote:
> > > On Tue, Dec 04, 2007 at 07:28:00PM -0600, Timur Tabi wrote:
> > > > Scott Wood wrote:
> > > >
> > > >> The physical address certainly is useful when you have more than one
> > > >> device of the same name.
> > > >
> > > > What I meant was that the physical address isn't helpful by itself.
> > > >
> > > >> So then you'd get "firmware-ucc.e01024". What if there's another ucc at
> > > >> e0102480? For devices with longer names, you'd have even less precision
> > > >> in the address.
> > > >
> > > > Maybe we need to consider a more sophisticated algorithm, one that
> > > > guarantees that the device name in its entirety is preserved? Either that,
> > > > or replace the physical address with something shorter, like the offset to
> > > > the root node only? That way, ucc.e0102400 because just ucc.2400.
> > >
> > > You should do something :)
> > >
> > > In the near future (2.6.26) there will not be a limit on the size of the
> > > file name, so we should not have this problem anymore.
> >
> > Not even .25 ? damn ! Any way that fix can be fastracked ? This
> > limitation has been a major PITA for some time now (this is just -one-
> > example where it gets in the way).
>
> I'll let Kay answer that, last he said, it involves a _lot_ of changes
> throughout the kernel :(
The current patch gets rid of bus_id and uses the dynamic kobject_name
directly all over the place. It's huge, because the current code expects
a static array and uses strncpy/snprintf all over the place.
I'm currently waiting for the new kobject api to finish, before I update
the patch, not sure if we will make it in time for .25.
Kay
prev parent reply other threads:[~2007-12-15 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 23:45 Fix Firmware class name collision Timur Tabi
2007-12-04 23:52 ` Scott Wood
2007-12-05 1:28 ` Timur Tabi
2007-12-14 22:40 ` Greg KH
2007-12-14 22:46 ` Timur Tabi
2007-12-15 6:14 ` Benjamin Herrenschmidt
2007-12-15 6:39 ` Greg KH
2007-12-15 15:46 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197733615.19869.30.camel@lov.site \
--to=kay.sievers@vrfy$(echo .)org \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=gregkh@suse$(echo .)de \
--cc=markus.rechberger@amd$(echo .)com \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox