From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Anton Blanchard <anton@samba•org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] Fix PMU + soft interrupt disable bug
Date: Mon, 17 Mar 2008 19:51:45 +1100 [thread overview]
Message-ID: <1205743905.26869.161.camel@pasglop> (raw)
In-Reply-To: <20080317042709.GA10594@kryten>
On Sun, 2008-03-16 at 23:27 -0500, Anton Blanchard wrote:
> Since the PMU is an NMI now, it can come at any time we are only soft
> disabled. We must hard disable around the two places we allow the kernel
> stack SLB and r1 to go out of sync. Otherwise the PMU exception can
> force a kernel stack SLB into another slot.
>
> Signed-off-by: Anton Blanchard <anton@samba•org>
Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
---
> ---
>
> Index: kernel/arch/powerpc/mm/slb.c
> ===================================================================
> --- kernel.orig/arch/powerpc/mm/slb.c 2007-11-05 11:22:03.000000000 -0600
> +++ kernel/arch/powerpc/mm/slb.c 2007-11-05 18:09:45.000000000 -0600
> @@ -113,6 +113,12 @@ void slb_flush_and_rebolt(void)
> slb_shadow_update(get_paca()->kstack, lflags, 2);
> }
>
> + /*
> + * We can't take a PMU exception in the following code, so hard
> + * disable interrupts.
> + */
> + hard_irq_disable();
> +
> /* We need to do this all in asm, so we're sure we don't touch
> * the stack between the slbia and rebolting it. */
> asm volatile("isync\n"
> Index: kernel/arch/powerpc/kernel/process.c
> ===================================================================
> --- kernel.orig/arch/powerpc/kernel/process.c 2007-11-05 18:10:44.000000000 -0600
> +++ kernel/arch/powerpc/kernel/process.c 2007-11-05 18:10:46.000000000 -0600
> @@ -331,6 +331,12 @@ struct task_struct *__switch_to(struct t
> account_process_vtime(current);
> calculate_steal_time();
>
> + /*
> + * We can't take a PMU exception inside _switch() since there is a
> + * window where the kernel stack SLB and the kernel stack are out
> + * of sync. Hard disable here.
> + */
> + hard_irq_disable();
> last = _switch(old_thread, new_thread);
>
> local_irq_restore(flags);
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs•org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2008-03-17 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 4:27 [PATCH] Fix PMU + soft interrupt disable bug Anton Blanchard
2008-03-17 8:51 ` Benjamin Herrenschmidt [this message]
2008-03-18 0:36 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205743905.26869.161.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=anton@samba$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox