Subject: Re: new warnings from stacktrace patch

From: Benjamin Herrenschmidt <[email-masked]>
Date: Thu, 24 Apr 2008 10:44:21 +1000

On Wed, 2008-04-23 at 16:32 +0200, Christoph Hellwig wrote:
> On Wed, Apr 23, 2008 at 05:59:38PM +1000, Stephen Rothwell wrote:
> > This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
> > Stacktrace support for lockdep").  We don't include asm-offsets.h in any
> > other C file in the powerpc build.
> 
> I think the include can be safely removed.

Yup. It's a leftover from before I fixed up some stuff in ptrace.h

> 
> Signed-off-by: Christoph Hellwig <[email-masked]>

Ack.

> Index: linux-2.6/arch/powerpc/kernel/stacktrace.c
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/kernel/stacktrace.c	2008-04-23 15:28:05.000000000 +0200
> +++ linux-2.6/arch/powerpc/kernel/stacktrace.c	2008-04-23 15:28:16.000000000 +0200
> @@ -13,7 +13,6 @@
>  #include <linux/sched.h>
>  #include <linux/stacktrace.h>
>  #include <asm/ptrace.h>
> -#include <asm/asm-offsets.h>
>  
>  /*
>   * Save stack-backtrace addresses into a stack_trace buffer.
> _______________________________________________
> Linuxppc-dev mailing list
> [email-masked]
> https://ozlabs.org/mailman/listinfo/linuxppc-dev