Subject: Re: [Cbe-oss-dev] [PATCH] powerpc/cell: disable ptcal in case of kdump reboot

From: Michael Ellerman <[email-masked]>
Date: Thu, 12 Jun 2008 02:49:16 +1000

On Wed, 2008-06-11 at 18:28 +0200, Arnd Bergmann wrote:
> The ibm,cbe-start-ptcal rtas call transfers ownership
> of a memory range to the hardware in order to do
> periodic memory interface recalibration.
> When we do a kexec, we need to get this page back,
> so we don't step on the new kernel's toes.
> We used to do this correctly in case of a user triggered
> kexec, but not for kdump.

Used to?

> This patch disables ptcal from the cell specific
> machine_crash_shutdown() callback. 

I'd rather you used the crash_shutdown_register() infrastructure Mikey
added for EHEA - it's designed for just this sort of thing.

> I also needed to fix the pseries code that tries to install its
> default_machine_crash_shutdown() code independent
> of what machine we're running on.

That's a buglet.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person