Subject: Re: [PATCH] ibm_newemac: Add MII mode support to the EMAC RGMII bridge.

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 08 Jul 2008 10:46:06 +1000

On Mon, 2008-07-07 at 16:47 -0700, Grant Erickson wrote:
> 
> Would you prefer?
> 
>     +#define RGMII_FER_MII(idx)     RGMII_FER_GMII(idx)
> 
> Having the "extra" mnemonic makes the code end up looking less like a typo
> and more like a conscious decision: "Yes, we know MII and GMII are the same
> setting, but we're being explicit about it."

Yeah, that looks better. Either that or a comment. 

Cheers,
Ben.