Subject: Re: [RFC] [PATCH] task_pt_regs for powerpc systems

From: Benjamin Herrenschmidt <[email-masked]>
Date: Mon, 14 Jul 2008 19:06:57 +1000

On Mon, 2008-07-14 at 14:01 +0530, Srinivasa D S wrote:
> On Monday 14 July 2008 04:02:41 am Paul Mackerras wrote:
> > >  Below attached patch  defines this macro for powerpc arch. Please let
> > > me know your comments on this.
> > >
> > > +#define task_pt_regs(tsk)	((struct pt_regs *)(tsk)->thread.regs)
> >
> > The cast is unnecessary since tsk->thread.regs is already a struct
> > pt_regs *. 
> 
> True.
> 
> > Also note that tsk->thread.regs will be NULL for a kernel 
> > thread.
> 
> Yes, users of task_pt_regs will verify for NULL.  Updated patch attached 
> below.
> 
> Signed-off-by: Srinivasa DS <[email-masked]>

Can you send a cleanup patch against powerpc.git instead ?

Thanks !

Ben