From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Nathan Lynch <ntl@pobox•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] kill useless SMT code in prom_hold_cpus
Date: Tue, 15 Jul 2008 14:53:33 +1000 [thread overview]
Message-ID: <1216097613.7740.52.camel@pasglop> (raw)
In-Reply-To: <20080715022440.GU9594@localdomain>
On Mon, 2008-07-14 at 21:24 -0500, Nathan Lynch wrote:
> Benjamin Herrenschmidt wrote:
> > On Tue, 2008-07-08 at 17:36 -0500, Nathan Lynch wrote:
> > > I think this code that counts SMT threads and compares against NR_CPUS
> > > is an artifact of pre-powerpc-merge ppc64. We care about starting
> > > only primary threads in the OF client code.
> > >
> > > Signed-off-by: Nathan Lynch <ntl@pobox•com>
> >
> > That looks good. I'm not merging it right now because I want to dbl
> > check that it's allright on all SMT machines. IE. We compare reg[0]
> > against _prom->cpu now instead of interrupt_server[0] and I thus
> > want to ensure it's the same everywhere.
>
> Thanks. Looks like prom_find_boot_cpu is setting _prom->cpu to reg
> (or 0), so I think it should be fine... a system where reg differed
> from interrupt_server[0] would have been broken before this patch
> anyway, I think?
I tend to agree, just didn't have time to look closely / test before
I get to prepare my batch of patches for Linus, I'll stick it in the
next one.
Cheers,
Ben.
next prev parent reply other threads:[~2008-07-15 5:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 22:36 [PATCH] kill useless SMT code in prom_hold_cpus Nathan Lynch
2008-07-15 2:05 ` Benjamin Herrenschmidt
2008-07-15 2:24 ` Nathan Lynch
2008-07-15 4:53 ` Benjamin Herrenschmidt [this message]
2008-07-15 2:22 ` Tony Breeds
2008-07-15 4:55 ` Nathan Lynch
2008-07-15 4:59 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216097613.7740.52.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=ntl@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox