From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Adrian Bunk <bunk@kernel•org>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [2.6 patch] powerpc/boot/Makefile: change spaces to tabs
Date: Mon, 21 Jul 2008 10:59:13 +1000 [thread overview]
Message-ID: <1216601953.11027.63.camel@pasglop> (raw)
In-Reply-To: <20080717181854.GB18326@cs181140183.pp.htv.fi>
On Thu, 2008-07-17 at 21:18 +0300, Adrian Bunk wrote:
> For C code spaces versus tabs is just a religious issue,
> but for Makefiles it actually matters.
>
> This patch fixes he following errors:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:166: *** missing separator. Stop.
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:171: *** missing separator. Stop.
>
> Since this was inside an ifdef DTC_GENPARSER it was not a problem unless
> someone wanted to regenerate the shipped generated files.
>
> Signed-off-by: Adrian Bunk <bunk@kernel•org>
And that too :-)
Cheers,
Ben.
> ---
>
> arch/powerpc/boot/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -163,12 +163,12 @@ quiet_cmd_flex = FLEX $@
> cmd_flex = $(FLEX) -o$@ $<; cp $@ $@_shipped
>
> $(obj)/dtc-src/dtc-parser.tab.c: $(src)/dtc-src/dtc-parser.y FORCE
> - $(call if_changed,bison)
> + $(call if_changed,bison)
>
> $(obj)/dtc-src/dtc-parser.tab.h: $(obj)/dtc-src/dtc-parser.tab.c
>
> $(obj)/dtc-src/dtc-lexer.lex.c: $(src)/dtc-src/dtc-lexer.l FORCE
> - $(call if_changed,flex)
> + $(call if_changed,flex)
> endif
>
> #############
prev parent reply other threads:[~2008-07-21 0:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 18:18 [2.6 patch] powerpc/boot/Makefile: change spaces to tabs Adrian Bunk
2008-07-18 1:47 ` David Gibson
2008-07-21 0:59 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216601953.11027.63.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=bunk@kernel$(echo .)org \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox