From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Matt Carlson <mcarlson@broadcom•com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>,
Michael Chan <mchan@broadcom•com>, Nathan Lynch <ntl@pobox•com>,
netdev <netdev@vger•kernel.org>
Subject: Re: Strange tg3 regression with UMP fw. link reporting
Date: Sat, 09 Aug 2008 08:05:57 +1000 [thread overview]
Message-ID: <1218233157.24157.343.camel@pasglop> (raw)
In-Reply-To: <20080808184359.GB23249@HP-xw6200.broadcom.net>
On Fri, 2008-08-08 at 11:43 -0700, Matt Carlson wrote:
>
> Segher is right. The code should be 2.5 milliseconds but is actually
> much longer. This fix is actually already in my patch queue and needs
> to be sent upstream.
>
> We really shouldn't be displaying any error messages in the event of a
> timeout though. Earlier versions of the UMP firmware did not support
> the link update interface. The best thing the driver can do for all
> cases is give the firmware a chance to service the event but continue
> as if the event were serviced if it did not get an explicit ACK.
But that means that the driver will continuously spin 2.5ms every
timer tick or so ? Or do I miss something ? Could it be possible to
count timeouts and if after N attempts at an ack, they all timed out,
disable the feature completely ?
Or is there a way to test the version of the firmware ?
In any case, the fix should go into -stable as the problem is hurting
2.6.26. Also, should we consider updating the tg3 firmware on those
machines ?
Ben.
next prev parent reply other threads:[~2008-08-08 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 7:35 Strange tg3 regression with UMP fw. link reporting Benjamin Herrenschmidt
2008-08-08 8:58 ` Segher Boessenkool
2008-08-08 9:18 ` Benjamin Herrenschmidt
2008-08-08 18:43 ` Matt Carlson
2008-08-08 15:20 ` Michael Chan
2008-08-08 22:05 ` Benjamin Herrenschmidt [this message]
2008-08-08 20:20 ` Michael Chan
2008-08-08 21:25 ` Nathan Lynch
2008-08-08 9:21 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218233157.24157.343.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mcarlson@broadcom$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ntl@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox