Subject: Re: [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 19 Aug 2008 07:42:13 +1000

On Mon, 2008-08-18 at 18:34 -0400, roel kluin wrote:
> untested, is it correct?

Your patch is correct. The bug is quite harmless thankfully :-)

Ben.
 
> arch/powerpc/include/asm/pmac_feature.h:359:
> #define MACIO_FLAG_SCCA_ON  0x00000001
> #define MACIO_FLAG_SCCB_ON  0x00000002
> ---
> duplicate test of MACIO_FLAG_SCCB_ON
> 
> Signed-off-by: Roel Kluin <[email-masked]>
> ---
> diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> index 5169ecc..e6c0040 100644
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
>  	macio_chips[i].of_node	= node;
>  	macio_chips[i].type	= type;
>  	macio_chips[i].base	= base;
> -	macio_chips[i].flags	= MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
> +	macio_chips[i].flags	= MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
>  	macio_chips[i].name	= macio_names[type];
>  	revp = of_get_property(node, "revision-id", NULL);
>  	if (revp)