Subject: Re: [PATCH v3 3/4] powerpc/fsl-booke: Fixup 64-bit PTE reading for SMP support

From: Benjamin Herrenschmidt <[email-masked]>
Date: Thu, 04 Sep 2008 13:14:22 +1000

>  	FIND_PTE
>  	andc.	r13,r13,r11		/* Check permission */
> -	bne	2f			/* Bail if permission mismach */
>  
>  #ifdef CONFIG_PTE_64BIT
> -	lwz	r13, 0(r12)
> +#ifdef CONFIG_SMP
> +	subf	r10, r11, r12		/* create false data dep */
> +	lwzx	r13, r11, r10		/* Get upper pte bits */
> +#else
> +	lwz	r13, 0(r12)		/* Get upper pte bits */
>  #endif
> +#endif

Minor nit, but we don't usually use spaces after "," in asm.

Cheers,
Ben.