Subject: Re: [PATCH] Enable enhanced functions for 8536 TSEC

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 21 Oct 2008 10:54:35 +1100

On Thu, 2008-10-16 at 17:31 +0800, Jason Jin wrote:
> Signed-off-by: Jason Jin <[email-masked]>
> ---
>  arch/powerpc/boot/dts/mpc8536ds.dts |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8536ds.dts b/arch/powerpc/boot/dts/mpc8536ds.dts
> index 93fdd99..dce2f65 100644
> --- a/arch/powerpc/boot/dts/mpc8536ds.dts
> +++ b/arch/powerpc/boot/dts/mpc8536ds.dts
> @@ -180,7 +180,7 @@
>  		enet0: ethernet@24000 {
>  			cell-index = <0>;
>  			device_type = "network";
> -			model = "TSEC";
> +			model = "eTSEC";
>  			compatible = "gianfar";
>  			reg = <0x24000 0x1000>;
>  			local-mac-address = [ 00 00 00 00 00 00 ];

While this works, this isn't quite "proper" use of the device-tree,
you should instead have something like

compatible="gianfar-eTSEC","gianfar" or something like that

Cheers,
Ben.