Subject: Re: [PATCH] powerpc: Introduce MMU features v2

From: Michael Ellerman <[email-masked]>
Date: Tue, 09 Dec 2008 17:54:56 +1100

On Tue, 2008-12-09 at 17:46 +1100, Benjamin Herrenschmidt wrote:
> We're soon running out of CPU features and I need to add some new
> ones for various MMU related bits, so this patch separates the MMU
> features from the CPU features. I moved over the 32-bit MMU related
> ones, added base features for MMU type families, but didn't move
> over any 64-bit only feature yet.
> 
> Signed-off-by: Benjamin Herrenschmidt <[email-masked]>
> ---
> 
> Remove a spurrious character that broke 64-bit build
> 
>  arch/powerpc/include/asm/cputable.h       |   85 +++++++++-------------
>  arch/powerpc/include/asm/feature-fixups.h |   30 +++++++

You forgot to add tests of the feature fixup macros :)

See the bottom of arch/powerpc/lib/feature-fixup-test.S, it should only
require two lines.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person