Subject: Re: [PATCH 1/3] add of_find_next_cache_node()

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 16 Dec 2008 10:33:04 +1100

On Mon, 2008-12-15 at 16:33 -0600, Nathan Lynch wrote:
> Benjamin Herrenschmidt wrote:
> > On Wed, 2008-12-10 at 18:46 -0600, Nathan Lynch wrote:
> > > +       /* OF on pmac has nodes instead of properties named "l2-cache"
> > > +        * beneath CPU nodes.
> > > +        */
> > > +       if (!strcmp(np->type, "cpu"))
> > > +               for_each_child_of_node(np, child)
> > > +                       if (!strcmp(child->type, "cache"))
> > > +                               return child;
> > > +
> > 
> > pmac has both actually. And the property points to the node. It's a
> > problem for /proc/device-tree so we rename them iirc, but only in /proc,
> > ie, they should still be intact in the tree I think.
> 
> I see the 'l2-cache' property (renamed to 'l2-cache#1' in /proc) on a
> G4 iBook, but it is not present on the two G5 models I've checked.

Ah crap.

Oh well, keep your fallback then.

Don't 970MP have a shared L2 tho ? That will make it look like it's not,
I suppose there isn't much we can do about it tho...

Cheers,
Ben.