Subject: Re: [PATCH] powerpc/cell: fix the prototype of create_vma_map

From: Benjamin Herrenschmidt <[email-masked]>
Date: Wed, 07 Jan 2009 14:34:59 +1100

On Wed, 2009-01-07 at 10:58 +1100, Stephen Rothwell wrote:
> Signed-off-by: Stephen Rothwell <[email-masked]>
> ---
>  arch/powerpc/oprofile/cell/pr_util.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Arnd, I'm not too sure about this one, what do you think ? Shouldn't the
objectid be a u64 and the callers be fixed instead ?

Cheers,
Ben.

> diff --git a/arch/powerpc/oprofile/cell/pr_util.h b/arch/powerpc/oprofile/cell/pr_util.h
> index 628009c..dfdbffa 100644
> --- a/arch/powerpc/oprofile/cell/pr_util.h
> +++ b/arch/powerpc/oprofile/cell/pr_util.h
> @@ -79,7 +79,7 @@ struct spu_buffer {
>   * the vma-to-fileoffset map.
>   */
>  struct vma_to_fileoffset_map *create_vma_map(const struct spu *spu,
> -					     u64 objectid);
> +					     unsigned long objectid);
>  unsigned int vma_map_lookup(struct vma_to_fileoffset_map *map,
>  			    unsigned int vma, const struct spu *aSpu,
>  			    int *grd_val);
> -- 
> 1.6.0.5
>