Subject: Re: [PATCH] powerpc/cell: fix dependency in cpufreq

From: Michael Ellerman <[email-masked]>
Date: Tue, 10 Feb 2009 12:01:32 +1100

On Tue, 2009-02-10 at 11:46 +1100, Michael Neuling wrote:
> cbe_cpufreq.c uses cbe_cpufreq_has_pmi which is provided by
> cbe_cpufreq_pmi.c.  Hence CBE_CPUFREQ depends on CBE_CPUFREQ_PMI.
> 
> Signed-off-by: Michael Neuling <[email-masked]>
> ---
> I'm not 100% sure is this the right fix.  Should CBE_CPUFREQ really
> depend on CBE_CPUFREQ_PMI?

No I don't think it is. Look at platforms/cell/cbe_cpufreq.h, the
intention seems to be that if PMI isn't built in then that variable is
hardcoded to 0 and we never use the pmi routines.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person