Subject: Re: [PATCH] powerpc: Fix _PAGE_CHG_MASK

From: Benjamin Herrenschmidt <[email-masked]>
Date: Fri, 13 Feb 2009 16:46:55 +1100

On Fri, 2009-02-13 at 13:49 +1100, Benjamin Herrenschmidt wrote:

> > diff --git a/arch/powerpc/include/asm/pgtable-ppc32.h b/arch/powerpc/include/asm/pgtable-ppc32.h
> > index 75dded6..8298afc 100644
> > --- a/arch/powerpc/include/asm/pgtable-ppc32.h
> > +++ b/arch/powerpc/include/asm/pgtable-ppc32.h
> > @@ -428,8 +428,8 @@ extern int icache_44x_need_flush;
> >  #define PMD_PAGE_SIZE(pmd)	bad_call_to_PMD_PAGE_SIZE()
> >  #endif
> > 
> > -#define _PAGE_CHG_MASK	(PAGE_MASK | _PAGE_ACCESSED | _PAGE_DIRTY | _PAGE_SPECIAL)
> > -
> > +#define _PAGE_CHG_MASK	(PAGE_MASK | _PAGE_ACCESSED | _PAGE_DIRTY | \
> > +			 _PAGE_SPECIAL)
> > 
> >  #define PAGE_PROT_BITS	(_PAGE_GUARDED | _PAGE_COHERENT | _PAGE_NO_CACHE | \
> >  			 _PAGE_WRITETHRU | _PAGE_ENDIAN | \
> > 

BTW. That part of the patch looks bad (ie, the original line isn't what
is upstream). I've fixed up locally.

Cheers,
Ben.