From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Guillaume Knispel <gknispel@proformatique•com>
Cc: Linuxppc-dev@ozlabs•org
Subject: Re: OpenPIC / CPM2 PIC and cascading interrupt priorities
Date: Mon, 16 Feb 2009 08:04:20 +1100 [thread overview]
Message-ID: <1234731860.26036.95.camel@pasglop> (raw)
In-Reply-To: <20090215055040.41672e36@xilun.lan.proformatique.com>
> static void cpm2_cascade(unsigned int irq, struct irq_desc *desc)
> {
> int cascade_irq;
>
> while ((cascade_irq = cpm2_get_irq()) >= 0)
> generic_handle_irq(cascade_irq);
>
> desc->chip->eoi(irq);
> }
You can try doing an early EOI see that helps. Ie, stick it inside the loop,
after cpm_2_get_irq() and before generic_handle_irq() and see if that helps,
but make sure you do that EOI only once, ie, only on the first iteration.
Depending on how the CPM2 works, you may also be able to just get rid
of the loop... ie, if CPM2 output is level sensitive.
Ben.
next prev parent reply other threads:[~2009-02-15 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 4:50 OpenPIC / CPM2 PIC and cascading interrupt priorities Guillaume Knispel
2009-02-15 21:04 ` Benjamin Herrenschmidt [this message]
2009-02-15 23:32 ` Guillaume Knispel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234731860.26036.95.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=gknispel@proformatique$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox