From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Adrian Reber <adrian@lisas•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] Fix RTAS watchdog driver temperature read functionality
Date: Wed, 25 Mar 2009 08:00:33 +1100 [thread overview]
Message-ID: <1237928433.25062.725.camel@pasglop> (raw)
In-Reply-To: <20090324114505.GB24724@lisas.de>
On Tue, 2009-03-24 at 12:45 +0100, Adrian Reber wrote:
> On Tue, Mar 24, 2009 at 03:27:18PM +1100, Benjamin Herrenschmidt wrote:
> > On Mon, 2009-03-16 at 13:35 +0100, Adrian Reber wrote:
> > > Using the RTAS watchdog driver to read out the temperature crashes
> > > on a PXCAB:
> > >
> > > Unable to handle kernel paging request for data at address 0xfe347b50
> > > Faulting instruction address: 0xc00000000001af64
> > > Oops: Kernel access of bad area, sig: 11 [#1]
> > >
> > > This (removing "(void *)__pa") fixes it.
> >
> > Looks correct, but why not use rtas_get_sensor() instead ? (Exported by
> > arch/powerpc/kernel/rtas.c
>
> Ah, you mean something like?
Right, now turn it into a proper patch submission :-)
Cheers,
Ben.
> drivers/watchdog/wdrtas.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/wdrtas.c b/drivers/watchdog/wdrtas.c
> index 5d3b1a8..af2bbfa 100644
> --- a/drivers/watchdog/wdrtas.c
> +++ b/drivers/watchdog/wdrtas.c
> @@ -214,16 +214,14 @@ static void wdrtas_timer_keepalive(void)
> */
> static int wdrtas_get_temperature(void)
> {
> - long result;
> + int result;
> int temperature = 0;
>
> - result = rtas_call(wdrtas_token_get_sensor_state, 2, 2,
> - (void *)__pa(&temperature),
> - WDRTAS_THERMAL_SENSOR, 0);
> + result = rtas_get_sensor(WDRTAS_THERMAL_SENSOR, 0, &temperature);
>
> if (result < 0)
> printk(KERN_WARNING "wdrtas: reading the thermal sensor "
> - "faild: %li\n", result);
> + "faild: %i\n", result);
> else
> temperature = ((temperature * 9) / 5) + 32; /* fahrenheit */
>
> Adrian
next prev parent reply other threads:[~2009-03-24 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 12:35 [PATCH] Fix RTAS watchdog driver temperature read functionality Adrian Reber
2009-03-24 4:27 ` Benjamin Herrenschmidt
2009-03-24 11:45 ` Adrian Reber
2009-03-24 21:00 ` Benjamin Herrenschmidt [this message]
2009-03-25 3:49 ` Segher Boessenkool
2009-03-26 12:05 ` [PATCH v2] " Adrian Reber
2009-06-11 10:52 ` Adrian Reber
2009-06-25 11:22 ` Utz Bacher
2009-06-25 11:28 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237928433.25062.725.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=adrian@lisas$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox