public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Kumar Gala <kumar.gala@freescale•com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Broken CONFIG_HIGHPTE
Date: Wed, 01 Apr 2009 16:38:00 +1100	[thread overview]
Message-ID: <1238564280.17330.119.camel@pasglop> (raw)

Hi !

Just noticed... And I'll be travelling for a while so with no much
time to look at it.

Your changes to use the PTE page free batch via RCU on ppc32 broke
CONFIG_HIGHPTE for hash32...

You rely on passing a page_address() of the PTE page down to the
freeing layer. That doesn't work for highmem pages. That needs to
be changes to a struct page * on 32-bit (not on 64-bit where we
are using slabs though)

Cheers,
Ben.

             reply	other threads:[~2009-04-01  5:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01  5:38 Benjamin Herrenschmidt [this message]
2009-04-01 13:25 ` Broken CONFIG_HIGHPTE Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1238564280.17330.119.camel@pasglop \
    --to=benh@kernel$(echo .)crashing.org \
    --cc=kumar.gala@freescale$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox