From: Michael Ellerman <michael@ellerman•id.au>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Kumar Gala <kumar.gala@freescale•com>,
afleming@freescale•com
Subject: Re: [PATCH] powerpc/oprofile: dump_pmcs() is not used
Date: Wed, 08 Apr 2009 10:06:08 +1000 [thread overview]
Message-ID: <1239149168.6848.1.camel@localhost> (raw)
In-Reply-To: <AE9B4B27-F781-4C0B-9E17-79F3E7C78CF7@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On Tue, 2009-04-07 at 14:42 -0500, Kumar Gala wrote:
> On Apr 6, 2009, at 9:03 AM, Kumar Gala wrote:
>
> >
> > On Apr 6, 2009, at 8:45 AM, Michael Ellerman wrote:
> >
> >> Signed-off-by: Michael Ellerman <michael@ellerman•id.au>
> >> ---
> >> arch/powerpc/oprofile/op_model_fsl_emb.c | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> Or should we just remove it?
> >
> > I'm for removing it if Andy doesn't have any issues. Someone can
> > always add it back as debugfs code in the future if they want it.
>
> I chatted w/Andy and we both agreed to just remove the code rather
> than #if 0 it. If you send me a patch with that I'll apply it.
Cool, done.
Delegated to you in patchwork too. I was going to mark the old one as
superseded but I won't mess with it while it's delegated to you.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-04-08 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 13:45 [PATCH] powerpc/oprofile: dump_pmcs() is not used Michael Ellerman
2009-04-06 14:03 ` Kumar Gala
2009-04-07 19:42 ` Kumar Gala
2009-04-08 0:06 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239149168.6848.1.camel@localhost \
--to=michael@ellerman$(echo .)id.au \
--cc=afleming@freescale$(echo .)com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox