From: Michael Ellerman <michael@ellerman•id.au>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH] powerpc/pci: Move pseries code into pseries platform specific area
Date: Fri, 01 May 2009 08:52:58 +1000 [thread overview]
Message-ID: <1241131978.6928.0.camel@concordia> (raw)
In-Reply-To: <41163AE2-5EE9-4273-B2F2-373034AE4DC4@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On Thu, 2009-04-30 at 10:35 -0500, Kumar Gala wrote:
> On Apr 30, 2009, at 9:49 AM, Michael Ellerman wrote:
>
> > On Thu, 2009-04-30 at 09:14 -0500, Kumar Gala wrote:
> >> There doesn't appear to be any specific reason that we need to
> >> setup the
> >> pseries specific notifier in generic arch pci code. Move it into
> >> pseries
> >> land.
> >
> > Yeah I guess. Although if some other platform ever wants to do PCI
> > hotplug it probably wants to call update_dn_pci_info() also.
>
> when that happens we can worry about, also the code I moved is pretty
> pseries specific (seeing as the event is called PSERIES_RECONFIG_ADD)
Yeah I agree.
> >> --- a/arch/powerpc/platforms/pseries/setup.c
> >> +++ b/arch/powerpc/platforms/pseries/setup.c
> >> @@ -254,6 +255,31 @@ static void __init pseries_discover_pic(void)
> >> " interrupt-controller\n");
> >> }
> >>
> >> +extern void * update_dn_pci_info(struct device_node *dn, void
> >> *data);
> >
> > Ahem :)
>
> Yeah, was being lazy. I'll move it into asm/pci-bridge.h
Please do :)
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-04-30 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 14:14 [PATCH] powerpc/pci: Move pseries code into pseries platform specific area Kumar Gala
2009-04-30 14:49 ` Michael Ellerman
2009-04-30 15:35 ` Kumar Gala
2009-04-30 22:52 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241131978.6928.0.camel@concordia \
--to=michael@ellerman$(echo .)id.au \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox