From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: tiejun.china@gamil•com
Cc: linuxppc-dev@ozlabs•org, akpm@linux-foundation•org
Subject: Re: [v2 PATCH 1/1] Fix 64bit Maple Host Bridge 'reg' property
Date: Fri, 01 May 2009 15:02:21 +1000 [thread overview]
Message-ID: <1241154141.1781.1.camel@pasglop> (raw)
In-Reply-To: <1239704021-12431-1-git-send-email-tiejun.china@gamil.com>
On Tue, 2009-04-14 at 18:13 +0800, tiejun.china@gamil•com wrote:
> In the DTB tree created by firmware on some Maple 64bit targets, such as ATCA6101,
> the "reg" property of host bridge node is incorrectly encoded as if #address-cells
> and #size-cells were 1. So we have to provide one fixup function to fix that.
>
> Signed-off-by: Tiejun Chen <tiejun.china@gmail•com>
Almost there :-)
> + /* FIXME: This may be used for more Maple targets not only ATCA6101. */
> + node = call_prom("finddevice", 1, 1, ADDR("/"));
> + model = prom_getprop(node, "model", prop, sizeof(prop));
Couldn't you use _prom->root above ?
> + if (model != PROM_ERROR && (strcmp(prop, "Motorola,ATCA-6101") == 0))
> + fixup_device_tree_atca6101();
>
> name = "/ht@0/isa@4";
> isa = call_prom("finddevice", 1, 1, ADDR(name));
Cheers,
Ben.
prev parent reply other threads:[~2009-05-01 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 10:13 [v2 PATCH 1/1] Fix 64bit Maple Host Bridge 'reg' property tiejun.china
2009-05-01 5:02 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241154141.1781.1.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tiejun.china@gamil$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox