From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Torez Smith <lnxtorez@linux•vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S
Date: Mon, 18 May 2009 15:12:03 +1000 [thread overview]
Message-ID: <1242623523.18075.39.camel@pasglop> (raw)
In-Reply-To: <1242622146.31702.26.camel@torez.austin.ibm.com>
On Sun, 2009-05-17 at 23:49 -0500, Torez Smith wrote:
> File arch/powerpc/mm/tlb_nohash_low.S defines various processor specific low level TLB invalidation. Most all family of validations are grouped via pre-processor defines with the intent we error out if we reach the end and our platform is not represented. Given this, the last few lines of the file should look similar to the following....
> << SNIP >>
> 1: wrtee r10
> blr
> #else
> #error Unsupported processor type !
> #endif
>
> However, the #else is incorrectly written as #elif. On some of the newer compilers/assemblers, this will not successfully assemble and will cause an error.
Thanks, but it's been fixed already :-)
See commit b62c31ae401c6df25c61b206681a6e904ef97169.
Cheers,
Ben.
next prev parent reply other threads:[~2009-05-18 5:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 4:49 [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S Torez Smith
2009-05-18 5:12 ` Benjamin Herrenschmidt [this message]
2009-05-18 5:47 ` Stephen Rothwell
2009-05-18 5:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242623523.18075.39.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=lnxtorez@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox