Subject: Re: [PATCH v2] powerpc/pci: clean up direct access to sysdata by iseries platform

From: Benjamin Herrenschmidt <[email-masked]>
Date: Mon, 18 May 2009 17:05:05 +1000

On Fri, 2009-05-15 at 07:50 -0500, Kumar Gala wrote:
> On May 15, 2009, at 7:47 AM, Kumar Gala wrote:
> 
> > We shouldn't directly access sysdata to get the device node.  We  
> > should
> > be calling pci_device_to_OF_node().
> >
> > Signed-off-by: Kumar Gala <[email-masked]>
> > ---
> > * Updated based on sfr's iseries pci fix patch
> >
> > arch/powerpc/platforms/iseries/iommu.c |    2 +-
> > arch/powerpc/platforms/iseries/pci.c   |    8 ++++----
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> 
> Stephen if you can test this version that would be great.

Fails with:

/home/benh/linux-powerpc-test/arch/powerpc/platforms/iseries/iommu.c: In function ‘pci_dma_dev_setup_iseries’:
/home/benh/linux-powerpc-test/arch/powerpc/platforms/iseries/iommu.c:180: error: ‘dev’ undeclared (first use in this function)
/home/benh/linux-powerpc-test/arch/powerpc/platforms/iseries/iommu.c:180: error: (Each undeclared identifier is reported only once
/home/benh/linux-powerpc-test/arch/powerpc/platforms/iseries/iommu.c:180: error: for each function it appears in.)

(I suspect it should have been "pdev" instead of "dev")

Cheers,
Ben.