Subject: Re: [PATCH] powerpc/perfctr: Check oprofile_cpu_type for NULL before using it

From: David Woodhouse <[email-masked]>
Date: Thu, 06 Aug 2009 07:41:50 +0100

On Thu, 2009-08-06 at 14:02 +1000, Benjamin Herrenschmidt wrote:
> If the current CPU doesn't support performance counters,
> cur_cpu_spec->oprofile_cpu_type can be NULL. The current
> perfctr modules don't test for that case and would thus
> crash.

It can't actually be NULL on a 64-bit CPU; all 64-bit CPUs in the table
have ->oprofile_cpu_type set.

Of course, adding the check probably makes sense anyway.

-- 
David Woodhouse                            Open Source Technology Centre
[email-masked]                              Intel Corporation