From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Kyle McMartin <kyle@mcmartin•ca>
Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] fix ppc64 build failure on fedora
Date: Fri, 18 Sep 2009 11:50:06 +1000 [thread overview]
Message-ID: <1253238606.4932.23.camel@pasglop> (raw)
In-Reply-To: <20090917174144.GA11961@bombadil.infradead.org>
On Thu, 2009-09-17 at 13:41 -0400, Kyle McMartin wrote:
> From: Kyle McMartin <kyle@redhat•com>
>
> For some reason or another (newer gcc?) on Fedora 12 koji builders we're
> seeing _restgpr0_$n symbols instead of _restgpr_$n as handled in the
> prom_init_check.sh file:
> Checking prom_init.o symbol '_restgpr0_14'
> Error: External symbol '_restgpr0_14' referenced from prom_init.c
> Checking prom_init.o symbol '_restgpr0_17'
>
> Add cases to handle this to the filter portion of the script.
My concern tho is if one of thse is actually called ... we implement
them in arch/powerpc/lib/crtsaveres.S but with the "other" names..
Ben.
> Signed-off-by: Kyle McMartin <kyle@redhat•com>
> ---
>
> diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
> index 1ac136b..9f82f49 100644
> --- a/arch/powerpc/kernel/prom_init_check.sh
> +++ b/arch/powerpc/kernel/prom_init_check.sh
> @@ -52,12 +52,18 @@ do
> if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
> OK=1
> fi
> + if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
> + OK=1
> + fi
> if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
> OK=1
> fi
> if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
> OK=1
> fi
> + if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
> + OK=1
> + fi
> if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
> OK=1
> fi
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2009-09-18 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 17:41 [PATCH] fix ppc64 build failure on fedora Kyle McMartin
2009-09-17 17:57 ` Kyle McMartin
2009-09-18 1:50 ` Benjamin Herrenschmidt [this message]
2009-09-18 2:21 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253238606.4932.23.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=kyle@mcmartin$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox