From: Ian Munsie <imunsie@au1•ibm.com>
To: Masami Hiramatsu <mhiramat@redhat•com>
Cc: Peter Zijlstra <a.p.zijlstra@chello•nl>,
linux-kernel <linux-kernel@vger•kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat•com>,
Paul Mackerras <paulus@samba•org>,
Frederic Weisbecker <fweisbec@gmail•com>,
Ingo Molnar <mingo@elte•hu>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/2] perf: Move arch specific code into separate arch directory
Date: Tue, 13 Apr 2010 18:44:14 +1000 [thread overview]
Message-ID: <1271147886-sup-8960@au1.ibm.com> (raw)
In-Reply-To: <4BC313EF.4040406@redhat.com>
Hi Masami,
Thanks for the feedback
Excerpts from Masami Hiramatsu's message of Mon Apr 12 22:37:03 +1000 2010:
> Could you add a check whether the get_arch_regstr() is defined
> (or dwarf-regs.h is exist) in Makefile?
> If it is not defined, we'd better drop dwarf support(so set NO_DWARF),
> because it means we haven't ported perf probe on that architecture yet. :)
I was a little reluctant to do that when I first read your message
because it felt like adding autoconf stuff into the Makefile and the
code should already fail gracefully on architectures without the
register mappings. But, since the Makefile already has some autoconf
like magic and it would make the code cleaner, I'll play with the idea a
bit more tomorrow.
> > diff --git a/tools/perf/arch/x86/include/arch_dwarf-regs.h b/tools/perf/arch/x86/include/arch_dwarf-regs.h
> > new file mode 100644
> > index 0000000..9e8da6a
> > --- /dev/null
> > +++ b/tools/perf/arch/x86/include/arch_dwarf-regs.h
> > @@ -0,0 +1,6 @@
> > +#ifndef _PREF_ARCH_PPC_DWARF_REGS_H
> > +#define _PREF_ARCH_PPC_DWARF_REGS_H
>
> _PREF_ARCH_X86_DWARF_REGS_H ?
Nice catch (oops)
Cheers,
-Ian
prev parent reply other threads:[~2010-04-13 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 6:43 Ian Munsie
2010-04-12 6:43 ` [PATCH 1/2] perf: Move arch specific code into separate arch directory Ian Munsie
2010-04-12 6:43 ` [PATCH 2/2] perf probe: Add PowerPC DWARF register number mappings Ian Munsie
2010-04-12 12:40 ` Masami Hiramatsu
2010-04-12 12:37 ` [PATCH 1/2] perf: Move arch specific code into separate arch directory Masami Hiramatsu
2010-04-13 8:44 ` Ian Munsie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271147886-sup-8960@au1.ibm.com \
--to=imunsie@au1$(echo .)ibm.com \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=acme@redhat$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mhiramat@redhat$(echo .)com \
--cc=mingo@elte$(echo .)hu \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox