Subject: Re: [PATCH] powerpc: Fix integer constant warning

From: Steve Best <[email-masked]>
Date: Wed, 09 Jun 2010 07:50:07 -0400

On Tue, 2010-06-08 at 14:12 +0100, David Howells wrote:
> Steve Best <[email-masked]> wrote:
> 
> > -#define KERNELBASE (0xc000000000000000)
> > +#define KERNELBASE (0xc000000000000000ULL)
> 
> Is this the right fix?  The code producing the warning is subtracting
> 0xc000000000000000 from a 32-bit number:

agree this fix needs more work, and can be dropped. Paul has another
patch that removes this file, since it is no longer used. I assume we'll
go with that patch.
> 
> 	naca = ntohl(*((u_int32_t*) &inbuf[0x0C])) - KERNELBASE;
> 
> which seems distinctly odd.
> 
> David

-Steve