From: Ian Munsie <imunsie@au1•ibm.com>
To: Steven Rostedt <rostedt@goodmis•org>
Cc: Andreas Dilger <adilger@dilger•ca>,
Andreas Schwab <schwab@linux-m68k•org>,
Dave Kleikamp <shaggy@linux•vnet.ibm.com>,
DOCUMENTATION <linux-doc@vger•kernel.org>,
Namhyung Kim <namhyung@gmail•com>, Jiri Kosina <jkosina@suse•cz>,
Jason Baron <jbaron@redhat•com>,
linux-kernel <linux-kernel@vger•kernel.org>,
Alexander Graf <agraf@suse•de>, Ingo Molnar <mingo@redhat•com>,
Paul Mackerras <paulus@samba•org>,
KOSAKI Motohiro <kosaki.motohiro@jp•fujitsu.com>,
Frederic Weisbecker <fweisbec@gmail•com>,
Scott Wood <scottwood@freescale•com>,
Nathan Lynch <ntl@pobox•com>,
Andrew Morton <akpm@linux-foundation•org>,
David Gibson <dwg@au1•ibm.com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Avantika Mathur <mathur@linux•vnet.ibm.com>
Subject: Re: [PATCH 4/6] ftrace syscalls: Allow arch specific syscall symbol matching
Date: Thu, 03 Feb 2011 11:28:27 +1100 [thread overview]
Message-ID: <1296692691-sup-5940@au1.ibm.com> (raw)
In-Reply-To: <1296655484.10797.47.camel@gandalf.stny.rr.com>
Excerpts from Steven Rostedt's message of Thu Feb 03 01:04:44 +1100 2011:
> I'll answer your question here.
> > +#define arch_syscall_match_sym_name(sym, name) !strcmp(sym + 3, name + 3)
>
> Instead, you could have:
>
> #ifndef ARCH_HAS_SYSCALL_MATCH_SYM_NAME
>
> static inline arch_syscall_match_sym_name(const char *sym, const char *name)
> {
> return strcmp(sym + 3, name + 3) != 0;
> }
>
>
> If an arch needs to make its own, then it can simply override it by
> creating its own version and defining:
>
> #define ARCH_HAS_SYSCALL_MATCH_SYM_NAME
>
> Just like they do when an arch has its own strcmp.
Ok, I've changed it over. Just doing a quick regression test on ppc64 &
x86 then I'll repost.
Cheers,
-Ian
next prev parent reply other threads:[~2011-02-03 0:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 7:11 PowerPC, ftrace: Add PPC raw syscall tracepoints & ftrace fixes (mimimal subset only) v3 Ian Munsie
2011-02-02 7:11 ` [PATCH 1/6] ftrace syscalls: don't add events for unmapped syscalls Ian Munsie
2011-02-02 7:11 ` [PATCH 2/6] trace syscalls: Convert redundant syscall_nr checks into WARN_ON Ian Munsie
2011-02-02 7:11 ` [PATCH 3/6] ftrace syscalls: Make arch_syscall_addr weak Ian Munsie
2011-02-02 7:11 ` [PATCH 4/6] ftrace syscalls: Allow arch specific syscall symbol matching Ian Munsie
2011-02-02 14:04 ` Steven Rostedt
2011-02-02 14:15 ` [PATCH 4/6] ftrace syscalls: Allow arch specific syscallsymbol matching David Laight
2011-02-02 14:28 ` Steven Rostedt
2011-02-03 0:28 ` Ian Munsie [this message]
2011-02-02 7:11 ` [PATCH 5/6] trace, powerpc: Implement raw syscall tracepoints on PowerPC Ian Munsie
2011-02-02 7:11 ` [PATCH 6/6] trace syscalls: Early terminate search for sys_ni_syscall Ian Munsie
-- strict thread matches above, loose matches on Subject: below --
2011-02-03 3:27 PowerPC, ftrace: Add PPC raw syscall tracepoints & ftrace fixes (mimimal subset only) v4 Ian Munsie
2011-02-03 3:27 ` [PATCH 4/6] ftrace syscalls: Allow arch specific syscall symbol matching Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296692691-sup-5940@au1.ibm.com \
--to=imunsie@au1$(echo .)ibm.com \
--cc=adilger@dilger$(echo .)ca \
--cc=agraf@suse$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=dwg@au1$(echo .)ibm.com \
--cc=fweisbec@gmail$(echo .)com \
--cc=jbaron@redhat$(echo .)com \
--cc=jkosina@suse$(echo .)cz \
--cc=kosaki.motohiro@jp$(echo .)fujitsu.com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mathur@linux$(echo .)vnet.ibm.com \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@gmail$(echo .)com \
--cc=ntl@pobox$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=schwab@linux-m68k$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
--cc=shaggy@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox