Subject: Re: [PATCH][upstream] NAND Machine support for Integrated Flash Controller

From: Artem Bityutskiy <[email-masked]>
Date: Wed, 25 May 2011 10:20:22 +0300

Hi,

On Wed, 2011-05-25 at 09:30 +0530, Dipen Dudhat wrote:
> +	ret = nand_scan_tail(&priv->mtd);
> +	if (ret)
> +		goto err;
> +
> +#ifdef CONFIG_MTD_PARTITIONS

We've just removed this macro, it should be merged upstream soon, but it
is in the mtd tree so far.

> +	/* First look for RedBoot table or partitions on the command
> +	 * line, these take precedence over device tree information */
> +	ret = parse_mtd_partitions(&priv->mtd, part_probe_types, &parts, 0);
> +	if (ret < 0)
> +		goto err;

> +
> +#ifdef CONFIG_MTD_OF_PARTS
> +	if (ret == 0) {
> +		ret = of_mtd_parse_partitions(priv->dev, node, &parts);
> +		if (ret < 0)
> +			goto err;
> +	}
> +#endif

You should invent something to make sure you do not need #ifdef
CONFIG_MTD_OF_PARTS.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)