From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Anton Blanchard <anton@samba•org>
Cc: linuxppc-dev@lists•ozlabs.org, mikey@neuling•org, paulus@samba•org
Subject: Re: [PATCH 2/3] powerpc: POWER7 optimised memcpy using VMX
Date: Fri, 17 Jun 2011 15:57:16 +1000 [thread overview]
Message-ID: <1308290236.32158.47.camel@pasglop> (raw)
In-Reply-To: <20110617045421.615463021@samba.org>
O
> +.Lvmx_copy:
> + mflr r0
> + std r4,56(r1)
> + std r5,64(r1)
> + std r0,16(r1)
> + stdu r1,-STACKFRAMESIZE(r1)
> + bl .enable_kernel_altivec
> + ld r0,STACKFRAMESIZE+16(r1)
> + ld r3,STACKFRAMESIZE+48(r1)
> + ld r4,STACKFRAMESIZE+56(r1)
> + ld r5,STACKFRAMESIZE+64(r1)
> + mtlr r0
Disable interrupts ? We wont save the VMX state on interrupts and memcpy
is definitely re-entrant.
Or only run the optimization when not at interrupt time....
Cheers,
Ben.
next prev parent reply other threads:[~2011-06-17 5:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 4:53 [PATCH 0/3] POWER7 optimised copy loops Anton Blanchard
2011-06-17 4:53 ` [PATCH 1/3] powerpc: POWER7 optimised copy_page using VMX Anton Blanchard
2011-06-17 5:16 ` Michael Neuling
2011-06-17 5:26 ` Anton Blanchard
2011-06-17 5:43 ` Benjamin Herrenschmidt
2011-06-17 5:53 ` Benjamin Herrenschmidt
2011-06-17 20:26 ` Segher Boessenkool
2011-06-17 4:54 ` [PATCH 2/3] powerpc: POWER7 optimised memcpy " Anton Blanchard
2011-06-17 5:57 ` Benjamin Herrenschmidt [this message]
2011-06-17 7:12 ` Gabriel Paubert
2011-06-17 9:02 ` David Laight
2011-06-17 4:54 ` [PATCH 3/3] powerpc: POWER7 optimised copy_to_user/copy_from_user " Anton Blanchard
2011-06-17 5:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308290236.32158.47.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=anton@samba$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox