From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Will Drewry <wad@chromium•org>
Cc: linuxppc-dev@lists•ozlabs.org, fweisbec@gmail•com,
scarybeasts@gmail•com, djm@mindrot•org,
linux-kernel@vger•kernel.org, rostedt@goodmis•org,
segoon@openwall•com, tglx@linutronix•de,
Paul Mackerras <paulus@samba•org>,
kees.cook@canonical•com, jmorris@namei•org,
torvalds@linux-foundation•org, mingo@elte•hu
Subject: Re: [PATCH v9 11/13] powerpc: select HAVE_SECCOMP_FILTER and provide seccomp_execve
Date: Tue, 30 Aug 2011 15:28:03 +1000 [thread overview]
Message-ID: <1314682083.2488.73.camel@pasglop> (raw)
In-Reply-To: <1308875813-20122-11-git-send-email-wad@chromium.org>
On Thu, 2011-06-23 at 19:36 -0500, Will Drewry wrote:
> Facilitate the use of CONFIG_SECCOMP_FILTER by wrapping compatibility
> system call numbering for execve and selecting HAVE_SECCOMP_FILTER.
>
> v9: rebase on to bccaeafd7c117acee36e90d37c7e05c19be9e7bf
>
> Signed-off-by: Will Drewry <wad@chromium•org>
Seen these around for a while ... :-)
I don't see a harm in the patches per-se tho I haven't reviewed the
actual seccomp filter stuff and it's good (or bad) behaviour on ppc.
Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cheers,
Ben.
> ---
> arch/powerpc/Kconfig | 1 +
> arch/powerpc/include/asm/seccomp.h | 2 ++
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 2729c66..030d392 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -129,6 +129,7 @@ config PPC
> select HAVE_HW_BREAKPOINT if PERF_EVENTS && PPC_BOOK3S_64
> select HAVE_GENERIC_HARDIRQS
> select HAVE_SPARSE_IRQ
> + select HAVE_SECCOMP_FILTER
> select IRQ_PER_CPU
> select GENERIC_IRQ_SHOW
> select GENERIC_IRQ_SHOW_LEVEL
> diff --git a/arch/powerpc/include/asm/seccomp.h b/arch/powerpc/include/asm/seccomp.h
> index 00c1d91..3cb9cc1 100644
> --- a/arch/powerpc/include/asm/seccomp.h
> +++ b/arch/powerpc/include/asm/seccomp.h
> @@ -7,10 +7,12 @@
> #define __NR_seccomp_write __NR_write
> #define __NR_seccomp_exit __NR_exit
> #define __NR_seccomp_sigreturn __NR_rt_sigreturn
> +#define __NR_seccomp_execve __NR_execve
>
> #define __NR_seccomp_read_32 __NR_read
> #define __NR_seccomp_write_32 __NR_write
> #define __NR_seccomp_exit_32 __NR_exit
> #define __NR_seccomp_sigreturn_32 __NR_sigreturn
> +#define __NR_seccomp_execve_32 __NR_execve
>
> #endif /* _ASM_POWERPC_SECCOMP_H */
next prev parent reply other threads:[~2011-08-30 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1308875813-20122-1-git-send-email-wad@chromium.org>
2011-06-24 0:36 ` [PATCH v9 11/13] powerpc: select HAVE_SECCOMP_FILTER and provide seccomp_execve Will Drewry
2011-08-30 5:28 ` Benjamin Herrenschmidt [this message]
2011-11-28 0:14 ` Benjamin Herrenschmidt
2011-11-28 1:45 ` Will Drewry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314682083.2488.73.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=djm@mindrot$(echo .)org \
--cc=fweisbec@gmail$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=kees.cook@canonical$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=paulus@samba$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=scarybeasts@gmail$(echo .)com \
--cc=segoon@openwall$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=wad@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox