Subject: Re: [PATCH 1/6] 44x/pci: Continue pci setup even if there is no sdr-base in the device-tree

From: Benjamin Herrenschmidt <[email-masked]>
Date: Wed, 30 Nov 2011 16:46:13 +1100

On Wed, 2011-11-30 at 16:23 +1100, Tony Breeds wrote:
> Signed-off-by: Tony Breeds <[email-masked]>
> ---
>  arch/powerpc/sysdev/ppc4xx_pci.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/ppc4xx_pci.c b/arch/powerpc/sysdev/ppc4xx_pci.c
> index 16f5eba..d3fa380 100644
> --- a/arch/powerpc/sysdev/ppc4xx_pci.c
> +++ b/arch/powerpc/sysdev/ppc4xx_pci.c
> @@ -1974,11 +1974,11 @@ static void __init ppc4xx_probe_pciex_bridge(struct device_node *np)
>  	port->node = of_node_get(np);
>  	pval = of_get_property(np, "sdr-base", NULL);
>  	if (pval == NULL) {
> -		printk(KERN_ERR "PCIE: missing sdr-base for %s\n",
> +		printk(KERN_INFO "PCIE: missing sdr-base for %s\n",
>  		       np->full_name);

If you don't expect an sdr-base as part of the normal operations of that
bridge, don't bring a message that makes me think something is wrong :-)

Just changing the severity isn't enough. you should just remove the
message and later on, print/warn/error out if you decide you actually
need an sdr-base (such as in the backend).

Cheers,
Ben.

> -		return;
> +	} else {
> +		port->sdr_base = *pval;
>  	}
> -	port->sdr_base = *pval;
>  
>  	/* Check if device_type property is set to "pci" or "pci-endpoint".
>  	 * Resulting from this setup this PCIe port will be configured