From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Russell King - ARM Linux <linux@arm•linux.org.uk>
Cc: linux-m32r-ja@ml•linux-m32r.org, linux-mips@linux-mips•org,
linux-ia64@vger•kernel.org, linux-doc@vger•kernel.org,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Randy Dunlap <rdunlap@xenotime•net>,
Paul Mackerras <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
sparclinux@vger•kernel.org, Sven Eckelmann <sven@narfation•org>,
linux-arch@vger•kernel.org, linux-s390@vger•kernel.org,
Arnd Bergma nn <arnd@arndb•de>,
linux-hexagon@vger•kernel.org, Helge Deller <deller@gmx•de>,
x86@kernel•org, "James E.J. Bottomley" <jejb@parisc-linux•org>,
Ingo Molnar <mingo@redhat•com>, Matt Turner <mattst88@gmail•com>,
Fenghua Yu <fenghua.yu@intel•com>,
user-mode-linux-devel@lists•sourceforge.net,
Jeff Dike <jdike@addtoit•com>,
linux-alpha@vger•kernel.org, Chris Metcalf <cmetcalf@tilera•com>,
Tony Luck <tony.luck@intel•com>,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org,
Richard Henderson <rth@twiddle•net>,
linux-m32r@ml•linux-m32r.org, linux-parisc@vger•kernel.org,
b.a.t.m.a.n@lists•open-mesh.org, linux-kernel@vger•kernel.org,
Ralf Baechle <ralf@linux-mips•org>,
"David S. Miller" <davem@davemloft•net>,
Kyle McMartin <kyle@mcmartin•ca>,
Richard Weinberger <richard@nod•at>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
linux390@de•ibm.com, Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
Hirokazu Takata <takata@linux-m32r•org>
Subject: Re: Re: [PATCHv5] atomic: add *_dec_not_zero
Date: Mon, 05 Dec 2011 09:41:55 +1100 [thread overview]
Message-ID: <1323038515.11728.26.camel@pasglop> (raw)
In-Reply-To: <20111204221850.GC14542@n2100.arm.linux.org.uk>
On Sun, 2011-12-04 at 22:18 +0000, Russell King - ARM Linux wrote:
.../...
> And really, I believe it would be a good cleanup if all the standard
> definitions for atomic64 ops (like atomic64_add_negative) were also
> defined in include/linux/atomic.h rather than individually in every
> atomic*.h header throughout the kernel source, except where an arch
> wants to explicitly override it. Yet again, virtually all architectures
> define these in exactly the same way.
>
> We have more than enough code in arch/ for any architecture to worry
> about, we don't need schemes to add more when there's simple and
> practical solutions to avoiding doing so if the right design were
> chosen (preferably from the outset.)
>
> So, I'm not going to offer my ack for a change which I don't believe
> is the correct approach.
I agree with Russell, his approach is a lot easier to maintain long run,
we should even consider converting existing definitions.
Cheers,
Ben.
next prev parent reply other threads:[~2011-12-04 22:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 15:42 [PATCHv5] atomic: add *_dec_not_zero Sven Eckelmann
2011-12-04 21:33 ` Russell King - ARM Linux
2011-12-04 21:49 ` Sven Eckelmann
2011-12-04 22:18 ` Russell King - ARM Linux
2011-12-04 22:41 ` Benjamin Herrenschmidt [this message]
2011-12-05 0:14 ` H. Peter Anvin
2011-12-05 7:57 ` Re: " Sven Eckelmann
2011-12-05 8:26 ` Benjamin Herrenschmidt
2011-12-04 22:42 ` Sven Eckelmann
2011-12-05 11:44 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323038515.11728.26.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=b.a.t.m.a.n@lists$(echo .)open-mesh.org \
--cc=cmetcalf@tilera$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=fenghua.yu@intel$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jdike@addtoit$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=kyle@mcmartin$(echo .)ca \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m32r-ja@ml$(echo .)linux-m32r.org \
--cc=linux-m32r@ml$(echo .)linux-m32r.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=richard@nod$(echo .)at \
--cc=rth@twiddle$(echo .)net \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=sven@narfation$(echo .)org \
--cc=takata@linux-m32r$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox