From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: "tiejun.chen" <tiejun.chen@windriver•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2 0/3] ppc32/kprobe: Fix a bug for kprobe stwu r1
Date: Wed, 11 Jan 2012 11:53:19 +1100 [thread overview]
Message-ID: <1326243199.23910.81.camel@pasglop> (raw)
In-Reply-To: <4F0C01BA.3040302@windriver.com>
On Tue, 2012-01-10 at 17:15 +0800, tiejun.chen wrote:
> Tiejun Chen wrote:
> > Changes from V1:
> >
> > * use memcpy simply to withdraw copy_exc_stack
> > * add !(regs->msr & MSR_PR)) and
> > WARN_ON(test_thread_flag(TIF_EMULATE_STACK_STORE));
> > to make sure we're in goot path.
> > * move this migration process inside 'restore'
> > * clear TIF flag atomically
>
> Ben,
>
> Is this series OK?
Not completely sorry. I was about to send you some comments a couple of
weeks ago then had to leave urgently and forgot about it, then started
rewriting your code and didn't finish :-)
I'll give you some more feedback asap, sorry about that. It's getting
there but there's a couple of things I'd like to see done a bit
differently.
Cheers,
Ben.
> Thanks
> Tiejun
>
> >
> > Tiejun Chen (3):
> > powerpc/kprobe: introduce a new thread flag
> > ppc32/kprobe: complete kprobe and migrate exception frame
> > ppc32/kprobe: don't emulate store when kprobe stwu r1
> >
> > arch/powerpc/include/asm/thread_info.h | 3 ++
> > arch/powerpc/kernel/entry_32.S | 35 ++++++++++++++++++++++++++++++++
> > arch/powerpc/lib/sstep.c | 25 +++++++++++++++++++++-
> > 3 files changed, 61 insertions(+), 2 deletions(-)
> >
> > Tiejun
prev parent reply other threads:[~2012-01-11 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 11:00 [PATCH v2 0/3] ppc32/kprobe: Fix a bug for kprobe stwu r1 Tiejun Chen
2011-12-15 11:00 ` [PATCH v2 1/3] powerpc/kprobe: introduce a new thread flag Tiejun Chen
2011-12-15 11:00 ` [PATCH v2 2/3] ppc32/kprobe: complete kprobe and migrate exception frame Tiejun Chen
2012-05-10 3:50 ` Benjamin Herrenschmidt
2012-06-03 5:01 ` tiejun.chen
2011-12-15 11:00 ` [PATCH v2 3/3] ppc32/kprobe: don't emulate store when kprobe stwu r1 Tiejun Chen
2012-01-10 9:15 ` [PATCH v2 0/3] ppc32/kprobe: Fix a bug for " tiejun.chen
2012-01-11 0:53 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326243199.23910.81.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tiejun.chen@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox