* [PATCH] powerpc/wsp: Permanently enable PCI class code workaround
@ 2012-02-05 23:50 Benjamin Herrenschmidt
2012-02-06 0:30 ` Stephen Rothwell
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2012-02-05 23:50 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Jimi Xenidis
It appears that on the Chroma card, the class code of the root
complex is still wrong even on DD2 or later chips. This could
be a firmware issue, but that breaks resource allocation so let's
unconditionally fix it up.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
---
arch/powerpc/platforms/wsp/wsp_pci.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/wsp/wsp_pci.c b/arch/powerpc/platforms/wsp/wsp_pci.c
index e0262cd..d24b3ac 100644
--- a/arch/powerpc/platforms/wsp/wsp_pci.c
+++ b/arch/powerpc/platforms/wsp/wsp_pci.c
@@ -468,15 +468,15 @@ static void __init wsp_pcie_configure_hw(struct pci_controller *hose)
#define DUMP_REG(x) \
pr_debug("%-30s : 0x%016llx\n", #x, in_be64(hose->cfg_data + x))
-#ifdef CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS
- /* WSP DD1 has a bogus class code by default in the PCI-E
- * root complex's built-in P2P bridge */
+ /*
+ * Some WSP variants has a bogus class code by default in the PCI-E
+ * root complex's built-in P2P bridge
+ */
val = in_be64(hose->cfg_data + PCIE_REG_SYS_CFG1);
pr_debug("PCI-E SYS_CFG1 : 0x%llx\n", val);
out_be64(hose->cfg_data + PCIE_REG_SYS_CFG1,
(val & ~PCIE_REG_SYS_CFG1_CLASS_CODE) | (PCI_CLASS_BRIDGE_PCI << 8));
pr_debug("PCI-E SYS_CFG1 : 0x%llx\n", in_be64(hose->cfg_data + PCIE_REG_SYS_CFG1));
-#endif /* CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS */
#ifdef CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS
/* XXX Disable TCE caching, it doesn't work on DD1 */
--
1.7.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/wsp: Permanently enable PCI class code workaround
2012-02-05 23:50 [PATCH] powerpc/wsp: Permanently enable PCI class code workaround Benjamin Herrenschmidt
@ 2012-02-06 0:30 ` Stephen Rothwell
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2012-02-06 0:30 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Jimi Xenidis, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
Hi Ben,
Just a small grammar correction:
On Mon, 06 Feb 2012 10:50:04 +1100 Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> - /* WSP DD1 has a bogus class code by default in the PCI-E
> - * root complex's built-in P2P bridge */
> + /*
> + * Some WSP variants has a bogus class code by default in the PCI-E
^^^^
have
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-06 0:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-05 23:50 [PATCH] powerpc/wsp: Permanently enable PCI class code workaround Benjamin Herrenschmidt
2012-02-06 0:30 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox