From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: akpm@linux-foundation•org
Cc: tj@kernel•org, linuxppc-dev@ozlabs•org, linasvepstas@gmail•com,
matt.fleming@intel•com, oleg@redhat•com
Subject: Re: [patch 1/2] powerpc/eeh: remove eeh_event_handler()->daemonize()
Date: Thu, 29 Mar 2012 10:22:48 +1100 [thread overview]
Message-ID: <1332976968.3010.0.camel@pasglop> (raw)
In-Reply-To: <20120328222057.B749EA0363@akpm.mtv.corp.google.com>
On Wed, 2012-03-28 at 15:20 -0700, akpm@linux-foundation•org wrote:
> From: Oleg Nesterov <oleg@redhat•com>
> Subject: powerpc/eeh: remove eeh_event_handler()->daemonize()
>
> daemonize() is only needed when a user-space task does kernel_thread().
>
> eeh_event_handler() thread is created by the worker kthread, and thus it
> doesn't need the soon-to-be-deprecated daemonize().
For some reason I thought you were sending that directly to Linus, but
looking at your CC list that's obviously not the case :-) I'll send
them myself.
Cheers,
Ben.
> Signed-off-by: Oleg Nesterov <oleg@redhat•com>
> Acked-by: Linas Vepstas <linasvepstas@gmail•com>
> Acked-by: Tejun Heo <tj@kernel•org>
> Acked-by: Matt Fleming <matt.fleming@intel•com>
> Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
> ---
>
> arch/powerpc/platforms/pseries/eeh_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize arch/powerpc/platforms/pseries/eeh_event.c
> --- a/arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize
> +++ a/arch/powerpc/platforms/pseries/eeh_event.c
> @@ -59,7 +59,7 @@ static int eeh_event_handler(void * dumm
> struct eeh_event *event;
> struct eeh_dev *edev;
>
> - daemonize("eehd");
> + set_task_comm(current, "eehd");
> set_current_state(TASK_INTERRUPTIBLE);
>
> spin_lock_irqsave(&eeh_eventlist_lock, flags);
> _
prev parent reply other threads:[~2012-03-28 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 22:20 [patch 1/2] powerpc/eeh: remove eeh_event_handler()->daemonize() akpm
2012-03-28 23:22 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332976968.3010.0.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linasvepstas@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=matt.fleming@intel$(echo .)com \
--cc=oleg@redhat$(echo .)com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox