* [patch 1/2] powerpc/eeh: remove eeh_event_handler()->daemonize()
@ 2012-03-28 22:20 akpm
2012-03-28 23:22 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2012-03-28 22:20 UTC (permalink / raw)
To: benh; +Cc: matt.fleming, oleg, linuxppc-dev, tj, akpm, linasvepstas
From: Oleg Nesterov <oleg@redhat•com>
Subject: powerpc/eeh: remove eeh_event_handler()->daemonize()
daemonize() is only needed when a user-space task does kernel_thread().
eeh_event_handler() thread is created by the worker kthread, and thus it
doesn't need the soon-to-be-deprecated daemonize().
Signed-off-by: Oleg Nesterov <oleg@redhat•com>
Acked-by: Linas Vepstas <linasvepstas@gmail•com>
Acked-by: Tejun Heo <tj@kernel•org>
Acked-by: Matt Fleming <matt.fleming@intel•com>
Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
arch/powerpc/platforms/pseries/eeh_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize arch/powerpc/platforms/pseries/eeh_event.c
--- a/arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize
+++ a/arch/powerpc/platforms/pseries/eeh_event.c
@@ -59,7 +59,7 @@ static int eeh_event_handler(void * dumm
struct eeh_event *event;
struct eeh_dev *edev;
- daemonize("eehd");
+ set_task_comm(current, "eehd");
set_current_state(TASK_INTERRUPTIBLE);
spin_lock_irqsave(&eeh_eventlist_lock, flags);
_
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch 1/2] powerpc/eeh: remove eeh_event_handler()->daemonize()
2012-03-28 22:20 [patch 1/2] powerpc/eeh: remove eeh_event_handler()->daemonize() akpm
@ 2012-03-28 23:22 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2012-03-28 23:22 UTC (permalink / raw)
To: akpm; +Cc: tj, linuxppc-dev, linasvepstas, matt.fleming, oleg
On Wed, 2012-03-28 at 15:20 -0700, akpm@linux-foundation•org wrote:
> From: Oleg Nesterov <oleg@redhat•com>
> Subject: powerpc/eeh: remove eeh_event_handler()->daemonize()
>
> daemonize() is only needed when a user-space task does kernel_thread().
>
> eeh_event_handler() thread is created by the worker kthread, and thus it
> doesn't need the soon-to-be-deprecated daemonize().
For some reason I thought you were sending that directly to Linus, but
looking at your CC list that's obviously not the case :-) I'll send
them myself.
Cheers,
Ben.
> Signed-off-by: Oleg Nesterov <oleg@redhat•com>
> Acked-by: Linas Vepstas <linasvepstas@gmail•com>
> Acked-by: Tejun Heo <tj@kernel•org>
> Acked-by: Matt Fleming <matt.fleming@intel•com>
> Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
> ---
>
> arch/powerpc/platforms/pseries/eeh_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize arch/powerpc/platforms/pseries/eeh_event.c
> --- a/arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize
> +++ a/arch/powerpc/platforms/pseries/eeh_event.c
> @@ -59,7 +59,7 @@ static int eeh_event_handler(void * dumm
> struct eeh_event *event;
> struct eeh_dev *edev;
>
> - daemonize("eehd");
> + set_task_comm(current, "eehd");
> set_current_state(TASK_INTERRUPTIBLE);
>
> spin_lock_irqsave(&eeh_eventlist_lock, flags);
> _
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-28 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-28 22:20 [patch 1/2] powerpc/eeh: remove eeh_event_handler()->daemonize() akpm
2012-03-28 23:22 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox