Subject: Re: [PATCH 01/15] i2c/powermac: Register i2c devices from device-tree

From: Benjamin Herrenschmidt <[email-masked]>
Date: Sun, 10 Jun 2012 17:23:01 +1000

On Sun, 2012-06-10 at 09:13 +0200, Andreas Schwab wrote:
> Benjamin Herrenschmidt <[email-masked]> writes:
> 
> > On Sun, 2012-06-10 at 00:59 +0200, Andreas Schwab wrote:
> >> It's a PowerMac G5.  During booting I see this:
> >
> > There's about half a dozen versions of those :-) I assume the older
> > PowerMac7,2 ?
> 
> Yes, that's right.  Sorry for being imprecise.
> 
> >> PowerMac i2c bus pmu 2 registered
> >> PowerMac i2c bus pmu 1 registered
> >> PowerMac i2c bus mac-io 0 registered
> >> i2c i2c-5: i2c-powermac: modalias failure
> >> on /ht@0,f2000000/pci@1/mac-io@7/i2c@18000/deq@6a
> >> i2c i2c-5: i2c-powermac: invalid reg
> >> on /ht@0,f2000000/pci@1/mac-io@7/i2c@18000/i2c-modem
> >> PowerMac i2c bus u3 1 registered
> >> i2c i2c-6: i2c-powermac: modalias failure
> >> on /u3@0,f8000000/i2c@f8001000/cereal@1c0
> >> PowerMac i2c bus u3 0 registered
> >> 
> >> The deq node has no compatible, perhaps the modalias can be
> >> constructed out of the name instead?
> >
> > But where is the deq node ? Under i2c or under sound ?
> 
> It looks like /ht@0,f2000000/pci@1/mac-io@7/i2c@18000/deq@6a is under
> i2c.

Ah, excellent, so a small quirk in i2c_powermac is the way to go then,
we can detect it by name and hack up something. Either that or even
better, in prom_init, we could add the missing property to the
device-tree.

Any chance you can try that ? (Look at other examples of DT fixups in
prom_init.c and don't forget the RELOC() around strings :-)

Cheers,
Ben.