From: Scott Wood <scottwood@freescale•com>
To: Wang Dongsheng-B40534 <B40534@freescale•com>
Cc: Wood Scott-B07421 <B07421@freescale•com>,
Li Yang-R58472 <r58472@freescale•com>,
"linux-pm@vger•kernel.org" <linux-pm@vger•kernel.org>,
Wang Dongsheng <dongsheng.wds@gmail•com>,
"linuxppc-dev@lists•ozlabs.org list"
<linuxppc-dev@lists•ozlabs.org>
Subject: Re: 答复: [RFC PATCH] powerpc/fsl: add timer wakeup source
Date: Tue, 9 Oct 2012 13:18:20 -0500 [thread overview]
Message-ID: <1349806700.26044.4@snotra> (raw)
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DF3F7F@039-SN2MPN1-021.039d.mgd.msft.net> (from B40534@freescale.com on Tue Oct 9 08:56:53 2012)
On 10/09/2012 08:56:53 AM, Wang Dongsheng-B40534 wrote:
>=20
> > > > > I'm pretty sure /proc/ is NOT where we want this exposed.
> > > >
> > > > Should probably go under the sysfs directory of the mpic =20
> device. Or
> > > > better, make a generic interface for timer-based suspend wakeup =20
> (if
> > > there
> > > > isn't one already). This current approach sits in an unpleasant
> > middle
> > > > ground between generic and device-specific.
> > > >
> > > /sys/power/wakeup_timer_seconds how about this?
> > > I think it is a freescale generic interface, this interface =20
> control by
> > > FSL_SOC && SUSPEND.
>=20
> > There's no such thing as a "Freescale generic interface". Linux =20
> APIs
> > are not organized by hardware vendor. Either make a truly generic
> > interface, reuse an existing one, or do something that is attached =20
> to
> > the specific driver.
> Thanks, I think i can change mpic timer registration, i will use =20
> platform_driver_register.
> I will merge "mpic timer" and "timer wakeup". In "mpic timer" the =20
> wakeup function
> controls by SUSPEND. The sys path is =20
> "/sys/devices/soc8572.4/ffe41100.timer/wakeup_seconds".
> do you have any suggestions for this? or have a better idea about the =20
> sys path?
I'm not sure what you mean by the merging, but the path looks OK (I'd =20
prefer a dash rather than underscore, but I'm not sure what the usual =20
practice is in sysfs).
That said, this seems like something that could use a truly generic =20
interface.
-Scott=
next prev parent reply other threads:[~2012-10-09 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 10:42 [RFC PATCH] powerpc/fsl: add timer wakeup source Wang Dongsheng
2012-10-03 13:35 ` Kumar Gala
2012-10-03 22:20 ` Scott Wood
2012-10-08 7:13 ` Wang Dongsheng-B40534
2012-10-08 20:55 ` Scott Wood
2012-10-09 13:56 ` 答复: " Wang Dongsheng-B40534
2012-10-09 18:18 ` Scott Wood [this message]
2012-12-13 15:51 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349806700.26044.4@snotra \
--to=scottwood@freescale$(echo .)com \
--cc=B07421@freescale$(echo .)com \
--cc=B40534@freescale$(echo .)com \
--cc=dongsheng.wds@gmail$(echo .)com \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=r58472@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox