From: "Phileas Fogg" <phileas-fogg@mail•ru>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re[5]: PS3 platform is broken on Linux 3.7.0
Date: Sun, 10 Feb 2013 21:51:37 +0400 [thread overview]
Message-ID: <1360518697.255951128@f337.mail.ru> (raw)
In-Reply-To: <87mwvc41fc.fsf@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]
>Phileas Fogg < phileas-fogg@mail•ru > writes:
>
>> Please ignore the previous patch to fix the PACA issue on PS3 arch.
>> This is the correct one:
>>
>> --- a/arch/powerpc/kernel/setup_64.c 2013-02-10 13:56:12.803855673 +0100
>> +++ b/arch/powerpc/kernel/setup_64.c 2013-02-10 14:07:22.870561322 +0100
>> @@ -186,6 +186,9 @@
>> initialise_paca(&boot_paca, 0);
>> setup_paca(&boot_paca);
>>
>> + /* Allow percpu accesses to "work" until we setup percpu data */
>> + boot_paca.data_offset = 0;
>> +
>> /* Initialize lockdep early or else spinlocks will blow */
>> lockdep_init();
>>
>>
>
>commit 466921c5a4669f4315528a25f9afd66601ce2c04 is done to fix the
>lockdep related issue on ppc64. So this may need little bit more
>explanation. So if we explicitly use boot_paca, do we still need the
>changes in the above commit ?
>
>-aneesh
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@lists•ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev
Ok, here is the next PACA fix test.
I tested the following patch with Linux 3.8.0-rc7 on PS3 arch and still getting panics.
Patch:
--- arch/powerpc/kernel/setup_64.c.old 2013-02-10 19:34:53.787366191 +0100
+++ arch/powerpc/kernel/setup_64.c 2013-02-10 19:35:38.834035478 +0100
@@ -186,6 +186,9 @@
initialise_paca(&boot_paca, 0);
setup_paca(&boot_paca);
+ /* Allow percpu accesses to "work" until we setup percpu data */
+ boot_paca.data_offset = 0;
+
/* Initialize lockdep early or else spinlocks will blow */
lockdep_init();
@@ -208,8 +211,6 @@
/* Fix up paca fields required for the boot cpu */
get_paca()->cpu_start = 1;
- /* Allow percpu accesses to "work" until we setup percpu data */
- get_paca()->data_offset = 0;
/* Probe the machine type */
probe_machine();
It seems that 'boot_paca' and 'get_paca()' refer to different PACAs.
regards
[-- Attachment #2: Type: text/html, Size: 3151 bytes --]
next prev parent reply other threads:[~2013-02-10 17:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 12:35 PS3 platform is broken on Linux 3.7.0 Phileas Fogg
2012-12-19 21:53 ` Benjamin Herrenschmidt
2013-01-12 2:12 ` Geoff Levand
2013-01-14 23:37 ` Geoff Levand
2013-02-10 8:59 ` Re[2]: " Phileas Fogg
2013-02-10 9:16 ` Re[3]: " Phileas Fogg
2013-02-10 16:11 ` Aneesh Kumar K.V
2013-02-11 10:26 ` Aneesh Kumar K.V
2013-02-11 16:57 ` Re[5]: " Phileas Fogg
2013-02-12 1:11 ` Re[3]: " Geoff Levand
2013-02-11 20:56 ` Re[2]: " Geoff Levand
2013-02-10 11:45 ` Phileas Fogg
2013-02-10 12:17 ` Re[3]: " Phileas Fogg
2013-02-10 15:46 ` Aneesh Kumar K.V
2013-02-10 17:51 ` Phileas Fogg [this message]
2013-02-11 3:39 ` Michael Ellerman
2013-02-13 7:32 ` Geoff Levand
2013-02-13 22:37 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360518697.255951128@f337.mail.ru \
--to=phileas-fogg@mail$(echo .)ru \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox