public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale•com>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: linuxppc-dev@lists•ozlabs.org,
	Wang Dongsheng <dongsheng.wang@freescale•com>
Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation
Date: Thu, 14 Mar 2013 11:52:41 -0500	[thread overview]
Message-ID: <1363279961.28440.4@snotra> (raw)
In-Reply-To: <1363250273.4833.1.camel@jlt4.sipsolutions.net> (from johannes@sipsolutions.net on Thu Mar 14 03:37:53 2013)

On 03/14/2013 03:37:53 AM, Johannes Berg wrote:
> On Thu, 2013-03-14 at 11:36 +0800, Wang Dongsheng wrote:
>=20
> > +#ifdef CONFIG_PPC_BOOK3S_64
> >  	/* can't use RESTORE_SPECIAL(MSR) */
> >  	ld	r0, SL_MSR(r11)
> >  	mtmsrd	r0, 0
>=20
> Unfortunately, I forgot the reason for this comment, and didn't put a
> better one (almost 6 years ago!!)
>=20
> > +	RESTORE_SPECIAL(MSR)
>=20
> but maybe you also can't do this on BookE?

If it's because book3s needs mtmsrd instead of mtmsr, that doesn't =20
apply to booke.

-Scott=

  reply	other threads:[~2013-03-14 16:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  3:36 [PATCH] powerpc: add Book E support to 64-bit hibernation Wang Dongsheng
2013-03-14  8:37 ` Johannes Berg
2013-03-14 16:52   ` Scott Wood [this message]
2013-03-15 15:22     ` Johannes Berg
2013-03-18 22:12       ` Scott Wood
2013-03-19 20:55         ` Johannes Berg
2013-03-19 21:10           ` Scott Wood
2013-03-19 21:22             ` Johannes Berg
2013-03-19 22:16               ` Scott Wood
2013-03-22 10:58                 ` Johannes Berg
2013-03-22 22:14                   ` Scott Wood
2013-04-02  5:28                     ` Wang Dongsheng-B40534
2013-04-03  0:34                       ` Scott Wood
2013-04-03  5:36                         ` Wang Dongsheng-B40534
2013-04-03 20:15                           ` Scott Wood
2013-04-07  3:01                             ` Wang Dongsheng-B40534
2013-04-08 18:24                               ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363279961.28440.4@snotra \
    --to=scottwood@freescale$(echo .)com \
    --cc=dongsheng.wang@freescale$(echo .)com \
    --cc=johannes@sipsolutions$(echo .)net \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox