From: Johannes Berg <johannes@sipsolutions•net>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@lists•ozlabs.org,
Wang Dongsheng <dongsheng.wang@freescale•com>
Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation
Date: Fri, 22 Mar 2013 11:58:37 +0100 [thread overview]
Message-ID: <1363949917.8238.25.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1363731391.16671.32@snotra>
On Tue, 2013-03-19 at 17:16 -0500, Scott Wood wrote:
> > > I wonder about kernel modules, though flushing 32 MiB wouldn't be
> > > adequate there.
> >
> > Good question, but would they be running? You have to have everything
> > built in that you need to load the image? Or maybe not, with the
> > userspace image restoration that became possible at some point...
>
> Is that all that's being restored in this step, or would we be loading
> all modules that were loaded before suspend (as they're normally not
> swappable)? I'm not too familiar with what gets saved where.
Yes, they would be restored since full memory is restored, but the
kernel doing the restore hasn't typically had a chance to load modules.
Although with uswsusp there probably are ways it can already have.
> > Maybe there's a way to completely flush the (i)cache? :-)
>
> There is, but it's platform-dependent, and not pleasant on our chips
> (need a displacement flush for L1, and sometimes errata are involved
> for L2).
:-)
I'll be the last one to tell you what to do, and I really don't remember
for sure why I did the flushing this way. It may very well be wrong for
what I thought I was doing, but it doesn't matter because I didn't need
to be doing it, I can't say any more now, too long ago. Sorry. May you
should ask Rafael what he thinks about flushing.
johannes
next prev parent reply other threads:[~2013-03-22 10:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 3:36 [PATCH] powerpc: add Book E support to 64-bit hibernation Wang Dongsheng
2013-03-14 8:37 ` Johannes Berg
2013-03-14 16:52 ` Scott Wood
2013-03-15 15:22 ` Johannes Berg
2013-03-18 22:12 ` Scott Wood
2013-03-19 20:55 ` Johannes Berg
2013-03-19 21:10 ` Scott Wood
2013-03-19 21:22 ` Johannes Berg
2013-03-19 22:16 ` Scott Wood
2013-03-22 10:58 ` Johannes Berg [this message]
2013-03-22 22:14 ` Scott Wood
2013-04-02 5:28 ` Wang Dongsheng-B40534
2013-04-03 0:34 ` Scott Wood
2013-04-03 5:36 ` Wang Dongsheng-B40534
2013-04-03 20:15 ` Scott Wood
2013-04-07 3:01 ` Wang Dongsheng-B40534
2013-04-08 18:24 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363949917.8238.25.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=dongsheng.wang@freescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox