Subject: Re: [PATCH V2] powerpc/MPIC: Add get_version API both for internal and external use

From: Scott Wood <[email-masked]>
Date: Fri, 29 Mar 2013 16:55:22 -0500

On 03/29/2013 04:51:59 PM, Scott Wood wrote:
> On 03/26/2013 12:28:10 AM, Jia Hongtao wrote:
>> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
>> index d30e6a6..c893a4b 100644
>> --- a/arch/powerpc/sysdev/mpic.c
>> +++ b/arch/powerpc/sysdev/mpic.c
>> @@ -1165,10 +1165,27 @@ static struct irq_domain_ops mpic_host_ops =3D =20
>> {
>>  	.xlate =3D mpic_host_xlate,
>>  };
>>=20
>> +static u32 mpic_get_version(struct mpic *mpic)
>> +{
>> +	u32 brr1;
>> +
>> +	brr1 =3D _mpic_read(mpic->reg_type, &mpic->thiscpuregs,
>> +			MPIC_FSL_BRR1);
>> +
>> +	return brr1 & MPIC_FSL_BRR1_VER;
>> +}
>> +
>>  /*
>>   * Exported functions
>>   */
>>=20
>> +u32 mpic_primary_get_version(void)
>> +{
>> +	struct mpic *mpic =3D mpic_primary;
>> +
>> +	return mpic_get_version(mpic);
>> +}
>=20
> So this just crashes if there is no mpic_primary or it's a non-FSL =20
> MPIC?

...and since it's specifically checking for the FSL version, "fsl" =20
should be in the name.

-Scott=