Subject: Re: [PATCH v3 8/8] powerpc/pseries: Read common partition via pstore

From: Benjamin Herrenschmidt <[email-masked]>
Date: Sat, 01 Jun 2013 14:52:47 +1000

On Thu, 2013-04-25 at 15:49 +0530, Aruna Balakrishnaiah wrote:

> diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
> index 8d4fb65..88cc050 100644
> --- a/fs/pstore/inode.c
> +++ b/fs/pstore/inode.c
> @@ -330,6 +330,9 @@ int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count,
>  	case PSTORE_TYPE_PPC_OF:
>  		sprintf(name, "of-%s-%lld", psname, id);
>  		break;

Call this powerpc-ofw-... Does it even contain something we use in Linux
at all ? Last I looked we only used the common one right ? Also it's
format afaik is defined in the CHRP bindings so it's not generic OFW
stuff, hence the powerpc prefix.

> +	case PSTORE_TYPE_PPC_COMMON:
> +		sprintf(name, "common-%s-%lld", psname, id);
> +		break;

Same deal, call that powerpc-common

>  	case PSTORE_TYPE_UNKNOWN:
>  		sprintf(name, "unknown-%s-%lld", psname, id);
>  		break;
> diff --git a/include/linux/pstore.h b/include/linux/pstore.h
> index 615dc18..656699f 100644
> --- a/include/linux/pstore.h
> +++ b/include/linux/pstore.h
> @@ -38,6 +38,7 @@ enum pstore_type_id {
>  	/* PPC64 partition types */
>  	PSTORE_TYPE_PPC_RTAS	= 4,
>  	PSTORE_TYPE_PPC_OF	= 5,
> +	PSTORE_TYPE_PPC_COMMON	= 6,
>  	PSTORE_TYPE_UNKNOWN	= 255
>  };

Do we expose anything else or keep it hidden ?

Cheers,
Ben.